Skip to content

Conversation

robstoll
Copy link
Contributor

IMO better to write out 'll because english beginners sometimes struggle with it

IMO better to write out `'ll` because english beginners sometimes struggle with it
@robstoll
Copy link
Contributor Author

Can someone re-trigger the build please, I doubt this has something to do with my change

@SethTisue
Copy link
Member

Yeah you can ignore the CI failure (though I believe it would go away if you rebase onto current main).

About your second edit though, you've rewritten it from "Because A, B" to "A, because B", which reverses the meaning. I would suggest "thus the dozens" instead of "because the dozens", but it's sort of a nitpick, wdyt?

@robstoll
Copy link
Contributor Author

robstoll commented Dec 17, 2021

I have changed the meaning because IMO it was wrong (I guess one knew what the author meant though). Maybe I get it wrong but IMO it's not that there are dozens of stdlib functions because you rarely write a for loop, you rarely write a for loop because there are dozens of stdlib functions. I also think that thus does not reflect this aspect as nice as because but I am not a native speaker.

@SethTisue SethTisue merged commit 198cd0d into scala:main Dec 17, 2021
@SethTisue
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants