Make outdated banner noisier, cleanup layouts #2634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
changed the title
julienrf
reviewed
Nov 17, 2022
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| layout: inner-page-no-masthead | |||
| layout: sip | |||
There was a problem hiding this comment.
That change needs to be applied here: https://github.com/scala/improvement-proposals/blob/main/content/trailing-commas.md
There was a problem hiding this comment.
julienrf
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outdated notice now is presented as sticky and in the main content window (floating above other sticky content such as the "need help" banner in getting started guide).
I also removed unused layouts, fixed misused layouts, and renamed layouts for clarity.
Also tour of scala layout includes the noscript notice for code tabs