New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrote currying tour #732

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@travissarles
Collaborator

travissarles commented Mar 16, 2017

No description provided.

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Mar 16, 2017

Member

I suggest renaming the whole section from "currying" to "multiple parameter lists", and never saying "curry" anywhere in the body text, either. Scala people don't normally talk about "currying".

I don't think you've chosen appropriate example code here — there is no good reason, that I can see anyway (and the text doesn't help me), to use multiple parameter lists for this function.

The old example code was unsatisfactory also.

I'd suggest looking for a commonly used method in the Scala standard library that has more than one parameter list. then show how use it, explain why it has multiple parameter lists, and then show how it could be defined. perhaps foldLeft?

Member

SethTisue commented Mar 16, 2017

I suggest renaming the whole section from "currying" to "multiple parameter lists", and never saying "curry" anywhere in the body text, either. Scala people don't normally talk about "currying".

I don't think you've chosen appropriate example code here — there is no good reason, that I can see anyway (and the text doesn't help me), to use multiple parameter lists for this function.

The old example code was unsatisfactory also.

I'd suggest looking for a commonly used method in the Scala standard library that has more than one parameter list. then show how use it, explain why it has multiple parameter lists, and then show how it could be defined. perhaps foldLeft?

@travissarles travissarles referenced this pull request Mar 17, 2017

Closed

Rewrite tour of Scala #733

33 of 33 tasks complete

@travissarles travissarles self-assigned this Mar 21, 2017

@SethTisue SethTisue changed the title from Rewrote curring tour to Rewrote currying tour May 30, 2017

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 9, 2018

Member

Maybe we can let this open so that a contributor can pick it up? Perhaps we should have a new label for this kind of stuff.

Member

jvican commented Jan 9, 2018

Maybe we can let this open so that a contributor can pick it up? Perhaps we should have a new label for this kind of stuff.

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jan 9, 2018

Member

Yes please, is there a volunteer who would like to get it over the finish line?

Member

SethTisue commented Jan 9, 2018

Yes please, is there a volunteer who would like to get it over the finish line?

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 9, 2018

Member

As you took the other one, I'll take this one.

Member

jvican commented Jan 9, 2018

As you took the other one, I'll take this one.

@jvican jvican self-assigned this Jan 9, 2018

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jan 11, 2018

Member

As we got many volunteers interested in the guides, I'm gonna see if someone dares to do this one! If there isn't one in two weeks, I'll take care of it 😄.

Member

jvican commented Jan 11, 2018

As we got many volunteers interested in the guides, I'm gonna see if someone dares to do this one! If there isn't one in two weeks, I'll take care of it 😄.

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jan 11, 2018

Member

replaced by #986

Member

SethTisue commented Jan 11, 2018

replaced by #986

@SethTisue SethTisue closed this Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment