Skip to content

Update scala-for-java-programmers.md #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2017
Merged

Update scala-for-java-programmers.md #912

merged 2 commits into from
Oct 31, 2017

Conversation

jfwm2
Copy link
Contributor

@jfwm2 jfwm2 commented Oct 31, 2017

Not sure if that change is scala-compliant, but if im<0, we should use the absolute value of im to avoid printing a leading minus sign.

@SethTisue
Copy link
Member

shorter if instead of adding an abs call, you change the if to read (if (im < 0) "" else "+"). nbd either way I guess?

@jfwm2
Copy link
Contributor Author

jfwm2 commented Oct 31, 2017

Indeed shorter!

@SethTisue SethTisue merged commit 0930dd2 into scala:master Oct 31, 2017
@SethTisue
Copy link
Member

good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfwm2 @SethTisue