New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new language tour section on type inference #985

Merged
merged 5 commits into from Jan 11, 2018

Conversation

Projects
None yet
2 participants
@SethTisue
Member

SethTisue commented Jan 11, 2018

original draft by @travissarles. touched up by me

replaces #737

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jan 11, 2018

Member

oh, I'll have to do something about this:

[tut] compiling: ./_tour/type-inference.md
[tut] *** Error reported at /drone/src/github.com/scala/docs.scala-lang/_tour/type-inference.md:64: failure was asserted but no failure occurred
obj: Null = null

(tut:fail expects everything inside to fail. so if you want to show some failing code that requires some correct code beforehand, you have to use two blocks)

Member

SethTisue commented Jan 11, 2018

oh, I'll have to do something about this:

[tut] compiling: ./_tour/type-inference.md
[tut] *** Error reported at /drone/src/github.com/scala/docs.scala-lang/_tour/type-inference.md:64: failure was asserted but no failure occurred
obj: Null = null

(tut:fail expects everything inside to fail. so if you want to show some failing code that requires some correct code beforehand, you have to use two blocks)

@SethTisue

This comment has been minimized.

Show comment
Hide comment
@SethTisue

SethTisue Jan 11, 2018

Member

I'm going to go ahead and merge, since #737 was open for feedback for many months.

Member

SethTisue commented Jan 11, 2018

I'm going to go ahead and merge, since #737 was open for feedback for many months.

@SethTisue SethTisue merged commit 76fdb81 into scala:master Jan 11, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@SethTisue SethTisue deleted the SethTisue:type-inference branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment