This repository has been archived by the owner on Feb 20, 2019. It is now read-only.
Add global reflection lock #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids data races that typically lead to runtime exceptions when running on Scala 2.10.x.
heathermiller
added a commit
that referenced
this pull request
Aug 20, 2014
Add global reflection lock
heathermiller
added a commit
that referenced
this pull request
Feb 5, 2015
Add global reflection lock
phaller
pushed a commit
to phaller/pickling
that referenced
this pull request
Jul 27, 2015
Add global reflection lock
|
So no locking required on Scala 2.11? |
|
@reactormonk Theoretically, yes. I'm still working on how to fix up GRL usage in the codebase for 0.11.x such that the 2.11 variant doesn't lock, but the 2.10 one does (at runtime). |
|
Maybe put the version-specific code into two different files and then add a version-specific exclude to https://github.com/scala/pickling/blob/0.10.x/build.sbt#L67-L71 ? I wonder which IDEs would pick that up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids data races that typically lead to runtime exceptions
when running on Scala 2.10.x.