Upgrade to scalafix v0.9.0 #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that mean that the changes proposed in #155 are not necessary? |
|
I had forgotten about that one, I will incorporate those changes into this PR next week 👍 |
This was referenced Oct 16, 2018
Closed
|
Incorporated the changes from #155 and addressed the remaining comment. This should be ready to go 💪 |
julienrf
reviewed
Oct 19, 2018
README.md
Outdated
| @@ -11,7 +11,7 @@ To use this library, add the following to your build.sbt: | |||
| libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "0.2.1" | |||
| ``` | |||
|
|
|||
| Version 0.2.1 is compatible with Scala 2.13.0-M5. For Scala 2.13.0-M4 you should use version 0.1.1. | |||
| Version 0.2.1 is compatible with Scala | |||
There was a problem hiding this comment.
Why did you remove that part?
There was a problem hiding this comment.
I blindly cherry-picked all commits from #155, added it back now.
| // build.sbt | ||
| scalafixDependencies += "org.scala-lang.modules" %% "scala-collection-migrations" % "0.2.1" | ||
| libraryDependencies += "org.scala-lang.modules" %% "scala-collection-compat" % "0.2.1" | ||
| scalacOptions ++= List("-Yrangepos", "-P:semanticdb:synthetics:on") |
There was a problem hiding this comment.
This should be wrapped in triple quotes or tildes.
README.md
Outdated
|
|
||
| ```scala | ||
| // project/plugins.sbt | ||
|
|
||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.7.0-RC1") | ||
| addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.9.0-RC1") |
There was a problem hiding this comment.
Good catch! Updated to 0.9.0
|
That looks good, thank you so much! |
julienrf
approved these changes
Oct 19, 2018
martijnhoekstra
pushed a commit
to martijnhoekstra/scala-collection-compat
that referenced
this pull request
Nov 9, 2022
Update sbt to 1.5.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #156