New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.12 community build omnibus ticket #203

Closed
adriaanm opened this Issue Aug 13, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@adriaanm
Member

adriaanm commented Aug 13, 2016

submit PRs based on forks (see commit mentions below)

@adriaanm adriaanm added this to the 2.12.0-RC1 milestone Aug 13, 2016

adriaanm added a commit to adriaanm/akka that referenced this issue Aug 13, 2016

adriaanm added a commit to adriaanm/slick that referenced this issue Aug 13, 2016

adriaanm added a commit to adriaanm/scala-js that referenced this issue Aug 13, 2016

@adriaanm

This comment has been minimized.

adriaanm added a commit to adriaanm/util that referenced this issue Aug 13, 2016

Instead of now-final Tuple2, extend Product2
Not sure the _1/_2 members are needed, but this is least impact.
You do lose pattern matching with , though.

Consider name-based pattern matching or making this a case class
to regain more efficient matching (that goes straight to the fields).

see scala/scala-dev#203

adriaanm added a commit to adriaanm/paradise that referenced this issue Aug 13, 2016

@adriaanm

This comment has been minimized.

Member

adriaanm commented Aug 14, 2016

https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/477/consoleFull:

util-core/src/test/java/com/twitter/concurrent/SpoolCompilationTest.java:13:
 <B>$plus$plus(scala.Function0<com.twitter.util.Future<com.twitter.concurrent.Spool<B>>>) 
in com.twitter.concurrent.Spool 
and <B>$plus$plus(scala.Function0<com.twitter.concurrent.Spool<B>>) 
in com.twitter.concurrent.Spool have the same erasure, 
yet neither overrides the other
private static class OwnSpool extends AbstractSpool<String> {

adriaanm added a commit to adriaanm/community-builds that referenced this issue Aug 14, 2016

adriaanm added a commit to adriaanm/community-builds that referenced this issue Aug 14, 2016

adriaanm added a commit to scala/community-builds that referenced this issue Aug 14, 2016

adriaanm added a commit to adriaanm/scala-js that referenced this issue Aug 19, 2016

ValDef may contribute exported method symbol
The ValDef of a trait val/deferred val in class/lazy val
has a method symbol, with the accessor DefDef following
later, in the fields phase

see scala/scala#5294

Community build follow-up: scala/scala-dev#203

adriaanm added a commit to adriaanm/scalaz that referenced this issue Aug 19, 2016

Implicit val needs signature...
... to be considered during implicit search before
the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203
@szeiger

This comment has been minimized.

szeiger commented Aug 29, 2016

Akka has added a dependency on scala-java8-compat in the meantime, so we need to add that to the community build: scala/community-builds#262

@szeiger szeiger referenced this issue Aug 31, 2016

Closed

add Scalactic #263

adriaanm added a commit to adriaanm/scalaz that referenced this issue Sep 1, 2016

Implicit val needs signature...
... to be considered during implicit search before
the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203

szeiger added a commit to szeiger/slick that referenced this issue Sep 1, 2016

@adriaanm adriaanm modified the milestones: 2.12.0, 2.12.0-RC1 Sep 6, 2016

xuwei-k added a commit to xuwei-k/scalaz that referenced this issue Sep 7, 2016

Implicit val needs signature to be considered during implicit search …
…before the position of said implicit val.

Revealed by: scala/scala#5294
Community build follow-up: scala/scala-dev#203

(cherry picked from commit dfb2c99)
@SethTisue

This comment has been minimized.

Member

SethTisue commented Sep 21, 2016

some additional old notes from Adriaan:

yep -- akka & sbinary are fixed in my forks
sbt is due to removal of exit
shapeless is junit not seeing default methods
sbinary is using a -Y option we removed (edited)

@milessabin

This comment has been minimized.

milessabin commented Sep 21, 2016

If there's anything you'd like me to do wrt shapeless to make your life easier please let me know.

@SethTisue SethTisue changed the title from community build to 2.12 community build omnibus ticket Sep 24, 2016

@SethTisue

This comment has been minimized.

Member

SethTisue commented Sep 24, 2016

the only remaining unchecked boxes here were macro-paradise (I opened scala/community-builds#302 on it) and ScalaTest (which is now #230)

and there's sbinary, but I'm less concerned about that one. maybe it'll get picked up in a future sweep

@SethTisue SethTisue closed this Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment