regression: 2.12.x release-package-windows keeps hanging

[SethTisue]

so e.g. https://scala-ci.typesafe.com/job/scala-2.12.x-release-package-windows/150/console

[error] Reference to undefined setting: 
[error] 
[error]   windows:packageBin from windows:packageBin (Y:\jenkins\workspace\scala-2.12.x-release-package-windows\build.sbt:24)
[error]  
[error] Use 'last' for the full log.
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore?

looks like sbt is hanging waiting for input.

it isn't intermittent, several consecutive runs hung and had to be manually aborted. (but since Jan 23, there haven't been further runs, pending resolution of #77)

• last green run: https://scala-ci.typesafe.com/job/scala-2.12.x-release-package-windows/148/console
  scala rev: scala/scala@93fa559
  scala-dist rev: scala/scala-dist@b2fccc9
• first aborted run: https://scala-ci.typesafe.com/job/scala-2.12.x-release-package-windows/149/consoleFull
  scala rev: scala/scala@a45a9ab
  scala-dist rev: scala/scala-dist@b8b1271

[SethTisue]

hmm, I may just need to merge the latest 2.11.x fixes in the scala-dist repo (addressing regressions due to the sbt-native-packager upgrade) onto 2.12.x. I'll try that next.

[SethTisue]

project/ScalaDist.scala has:

    if (sys.props("os.name").toLowerCase(java.util.Locale.US) contains "windows")
      Wix.settings :+ (mappings in upload += uploadMapping(packageBin in Windows).value)

project/Wix.scala customizes the Windows artifact name as follows:

    packageBin in Windows := {
      val versioned = target.value / s"${name.value}-${version.value}.msi"

      IO.copyFile((packageBin in Windows).value, versioned)
      versioned
    }

perhaps we should customize at upload time instead, a la scala/scala-dist@2d525f8? (still puzzled, though, why we would be forced to change approaches here, but I do think customizing at upload time is actually a cleaner solution anyway)

[SethTisue]

so in scala/scala-dist#160 I merged 2.11.x onto 2.12.x in the scala-dist repo, and it appears from the successful dry run at https://scala-ci.typesafe.com/job/scala-2.12.x-release-package-windows/155/ that the problem may be fixed. let's wait and see what happens tonight.

[SethTisue]

two greens in a row, so I figure this must be fixed.