-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.11.4 release. #242
Conversation
--- | ||
layout: news | ||
post-type: announcement | ||
title: "Scala 2.11.4 is now available!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be incorporated into make-release-notes tool in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and noted scala/make-release-notes#132
* [Scala specification](http://www.scala-lang.org/files/archive/spec/2.11/) received a fair amount of love and became much more beatiful. It has got syntax highlighting ([#3984](https://github.com/scala/scala/pull/3984)), linkable headers, and a side bar with TOC ([#3996](https://github.com/scala/scala/pull/3996)). A few final touches has been merged that fix typos and mistakes stemming from automatic Latex to Markdown conversion we've done a while ago. Thanks attention for details [@gourlaysama](https://github.com/gourlaysama), [@som-snytt](https://github.com/som-snytt) and [roberthoedicke](https://github.com/roberthoedicke)! | ||
* Non-deterministic pattern matching warnings has been fixed ([SI-7746](https://issues.scala-lang.org/browse/SI-7746)). Many thanks to [@gbasler](https://github.com/gbasler) for diving deep ([#3954](https://github.com/scala/scala/pull/3954])) into logical formulas constructed by our pattern matcher implementation! | ||
|
||
Compared to 2.11.2, this release resolves [54 issues](https://issues.scala-lang.org/issues/?jql=project%20%3D%20SI%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20in%20(%22Scala%202.11.3%22%2C%20%22Scala%202.11.4%22)%20ORDER%20BY%20component%20ASC%2C%20priority%20DESC). We reviewed and merged 120 [pull](https://github.com/scala/scala/pulls?q=is%3Apr+milestone%3A2.11.3) [requests](https://github.com/scala/scala/pulls?q=is%3Apr+milestone%3A2.11.4). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be hard for people to figure out that 'pull' and 'requests' are different links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't figured out better way to sneak in those two links. How about?
We reviewed and merged 120 pull requests (check this and this).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, fine for me. i couldn't manage to get a query on github that combines the two..
in the PR for 2.11.2 (ba4e7ad#diff-1) we also changed |
oh, sorry, i just saw now that this change was not about the 2.11.2 release - but they seem to have a newer version of activator available (https://typesafe.com/platform/getstarted) |
Yep, however it's a bit confusing we mix it with Scala release PR. I'd like to take care of it in separate PR and keep this minimal. |
To be squashed.
the advantage of keeping it together is that you can compare diffs when doing the next release. but i agree having two commits would be good: one with all the generated / automatic changes, one with the manual stuff. |
I added a commit with all review feedback incorporated. Lukas, could you have a look again? |
I'm going to get something to eat. I'll be back online in an hour or so. |
it seems some of the fixes are still missing: https://github.com/scala/scala-lang/pull/242/files#r19621427 and https://github.com/scala/scala-lang/pull/242/files#r19621801 |
Fixed. I was editing the wrong file... |
I think I've addressed all concerns. Could you guys take another look? |
We still missed https://github.com/scala/scala-lang/pull/242/files#r19621688, LGTM otherwise |
I'll submit a new PR. |
Thanks! My repair appointment got rescheduled so I can announce around noon. — On Fri, Oct 31, 2014 at 9:27 AM, Adriaan Moors notifications@github.com
|
No description provided.