Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.11.4 release. #242

Closed
wants to merge 5 commits into from
Closed

Conversation

gkossakowski
Copy link
Contributor

No description provided.

@gkossakowski
Copy link
Contributor Author

Review by @adriaanm or @lrytz.

I'd especially appreciate review of the hand written part of release notes.

---
layout: news
post-type: announcement
title: "Scala 2.11.4 is now available!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add

permalink: /news/2.11.4

we did that in 2.11.2 (918eb6e) - initially i got it wrong, it was fixed in e3554ba

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be incorporated into make-release-notes tool in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* [Scala specification](http://www.scala-lang.org/files/archive/spec/2.11/) received a fair amount of love and became much more beatiful. It has got syntax highlighting ([#3984](https://github.com/scala/scala/pull/3984)), linkable headers, and a side bar with TOC ([#3996](https://github.com/scala/scala/pull/3996)). A few final touches has been merged that fix typos and mistakes stemming from automatic Latex to Markdown conversion we've done a while ago. Thanks attention for details [@gourlaysama](https://github.com/gourlaysama), [@som-snytt](https://github.com/som-snytt) and [roberthoedicke](https://github.com/roberthoedicke)!
* Non-deterministic pattern matching warnings has been fixed ([SI-7746](https://issues.scala-lang.org/browse/SI-7746)). Many thanks to [@gbasler](https://github.com/gbasler) for diving deep ([#3954](https://github.com/scala/scala/pull/3954])) into logical formulas constructed by our pattern matcher implementation!

Compared to 2.11.2, this release resolves [54 issues](https://issues.scala-lang.org/issues/?jql=project%20%3D%20SI%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20in%20(%22Scala%202.11.3%22%2C%20%22Scala%202.11.4%22)%20ORDER%20BY%20component%20ASC%2C%20priority%20DESC). We reviewed and merged 120 [pull](https://github.com/scala/scala/pulls?q=is%3Apr+milestone%3A2.11.3) [requests](https://github.com/scala/scala/pulls?q=is%3Apr+milestone%3A2.11.4).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be hard for people to figure out that 'pull' and 'requests' are different links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't figured out better way to sneak in those two links. How about?

We reviewed and merged 120 pull requests (check this and this).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fine for me. i couldn't manage to get a query on github that combines the two..

@lrytz
Copy link
Member

lrytz commented Oct 30, 2014

in the PR for 2.11.2 (ba4e7ad#diff-1) we also changed _layouts/downloadpage.html

@lrytz
Copy link
Member

lrytz commented Oct 30, 2014

oh, sorry, i just saw now that this change was not about the 2.11.2 release - but they seem to have a newer version of activator available (https://typesafe.com/platform/getstarted)

@gkossakowski
Copy link
Contributor Author

Yep, however it's a bit confusing we mix it with Scala release PR. I'd like to take care of it in separate PR and keep this minimal.

@lrytz
Copy link
Member

lrytz commented Oct 30, 2014

the advantage of keeping it together is that you can compare diffs when doing the next release. but i agree having two commits would be good: one with all the generated / automatic changes, one with the manual stuff.

@gkossakowski
Copy link
Contributor Author

I added a commit with all review feedback incorporated. Lukas, could you have a look again?

@gkossakowski
Copy link
Contributor Author

I'm going to get something to eat. I'll be back online in an hour or so.

@lrytz
Copy link
Member

lrytz commented Oct 30, 2014

@gkossakowski
Copy link
Contributor Author

Fixed. I was editing the wrong file...

@gkossakowski
Copy link
Contributor Author

I think I've addressed all concerns. Could you guys take another look?

@lrytz
Copy link
Member

lrytz commented Oct 30, 2014

We still missed https://github.com/scala/scala-lang/pull/242/files#r19621688, LGTM otherwise

@adriaanm
Copy link
Contributor

I'll submit a new PR.

@adriaanm adriaanm closed this Oct 31, 2014
@gkossakowski
Copy link
Contributor Author

Thanks! My repair appointment got rescheduled so I can announce around noon.


Wysłano z Mailbox

On Fri, Oct 31, 2014 at 9:27 AM, Adriaan Moors notifications@github.com
wrote:

I'll submit a new PR.

Reply to this email directly or view it on GitHub:
#242 (comment)

@adriaanm adriaanm mentioned this pull request Oct 31, 2014
@gkossakowski gkossakowski deleted the 2.11.4 branch October 31, 2014 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants