Skip to content

Conversation

mslinn
Copy link
Contributor

@mslinn mslinn commented Sep 8, 2016

Here is a quick hack. It forces all code to white, enlarges it to 10 points and removes the annoying horizontal scroll bar. I do not care about an artistically beautiful color palette, I just want to be able to read the code.

Here is a quick hack. It forces all code to white, enlarges it to 10 points and removes the annoying horizontal scroll bar. I do not care about an artistically beautiful color palette, I just want to be able to read the code.
@SethTisue
Copy link
Member

@SethTisue
Copy link
Member

can someone help review this...?

@SethTisue
Copy link
Member

@mslinn your commit seems to have to disappeared from your fork of the repo? I think you may have deleted the branch the PR was submitted from?

@SethTisue
Copy link
Member

I see a couple problems here:

  • you've created duplicate entries in resources.css instead of updating the existing ones
  • all of the syntax highlighting is lost by forcing everything to white. this seems like a substantial loss to me. can we make the colors lighter without losing syntax highlighting?

@mslinn
Copy link
Contributor Author

mslinn commented Oct 18, 2016

@SethTisue As I originally stated, my goal was not to provide syntax highlighting, my goal was to simply make the text legible. It is merely a quick fix. If someone wants to provide syntax highlighting, they will probably want to take into consideration the color scheme for the rest of the site. I'm not taking that on.

@SethTisue
Copy link
Member

OK. I'm going to close with this without merging, then, but I invite the community to submit a new PR that improves legibility without losing the highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants