Skip to content

Provide a direct link to Java 8 download page #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

soronpo
Copy link
Contributor

@soronpo soronpo commented Nov 15, 2018

This is to prevent beginners from accidentally using Java 11, since it's not yet supported on mainstream Scala releases.
See also my comments on https://contributors.scala-lang.org/t/java-version-collision-for-beginners-weird-sbt-errors/2593

This is to avoid beginners from accidentally using Java 11, since it's not yet supported on mainstream Scala releases.
See also my comments on https://contributors.scala-lang.org/t/java-version-collision-for-beginners-weird-sbt-errors/2593
@nafg
Copy link
Contributor

nafg commented Nov 15, 2018

IIUC it works fine, although there are some JDK 9+ features that aren't supported yet, for instance you can't do Jigsaw modules. Also you get a warning because SBT uses protobufs which does something deprecated. I've been using JDK 10 for a while.

There's a different issue which is that from JDK 11, you should use the OpenJDK distribution. Everything it was missing it now has, and so the Oracle distribution only exists to be a proprietary version, and they've changed the license accordingly.

@SethTisue
Copy link
Member

it's true that basic Scala + sbt works fine on Java 11, but there are libraries and tooling that haven't caught up yet, so I agree that it's best to steer beginners towards Java 8 for now

@nafg
Copy link
Contributor

nafg commented Nov 15, 2018

@SethTisue in what sense? What doesn't work?

@ashawley
Copy link
Member

Sounds good.

Fix these two other pages that exist in the other repo as well?

@SethTisue
Copy link
Member

@SethTisue in what sense? What doesn't work?

I don't have a list handy and this PR isn't a good place to draft one, but it could be a good Discourse thread. (A possible outcome is that I'd be pleasantly surprised at how short a list we end up with.)

@soronpo
Copy link
Contributor Author

soronpo commented Nov 15, 2018

I don't have a list handy and this PR isn't a good place to draft one, but it could be a good Discourse thread. (A possible outcome is that I'd be pleasantly surprised at how short a list we end up with.)

Is it possible to run the community build with JDK 11 and report which libraries fail (both for 2.12 and 2.13)?

@soronpo
Copy link
Contributor Author

soronpo commented Nov 16, 2018

Sounds good.

Fix these two other pages that exist in the other repo as well?

* [Getting Started with Scala in IntelliJ](https://docs.scala-lang.org/getting-started-intellij-track/getting-started-with-scala-in-intellij.html)

* [Getting Started with Scala and sbt on the Command Line](https://docs.scala-lang.org/getting-started-sbt-track/getting-started-with-scala-and-sbt-on-the-command-line.html)

Glad to do it, but I can't seem to find its source. Any clue what generates this?

@SethTisue SethTisue merged commit a30bbcd into scala:master Nov 26, 2018
@SethTisue
Copy link
Member

someone want to follow up in the other repo?

@SethTisue
Copy link
Member

SethTisue commented Nov 26, 2018

Is it possible to run the community build with JDK 11 and report which libraries fail (both for 2.12 and 2.13)?

yes:

but note that what the community build tells is is whether something both builds and runs on JDK 11, provided all of its Scala-based dependencies also build and run okay on JDK 11. that's a high bar to meet, higher than the bar most users care about: users want to know whether the library runs okay on JDK 11 if it (and its Scala-based dependencies) were built on JDK 8, which is how nearly all published Scala libs were built

(this PR isn't the greatest place to discuss further)

@soronpo
Copy link
Contributor Author

soronpo commented Nov 27, 2018

someone want to follow up in the other repo?

Yes, I'll take care of that as well. PR soon. I'll link it here.

@soronpo
Copy link
Contributor Author

soronpo commented Jan 21, 2019

Added PR to docs.scala-lang repo here scala/docs.scala-lang#1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants