Skip to content

Conversation

He-Pin
Copy link

@He-Pin He-Pin commented Dec 13, 2018

More about Scala's business object.

@He-Pin
Copy link
Author

He-Pin commented Dec 13, 2018

image

image

image

image

image

image

@sjrd
Copy link
Member

sjrd commented Dec 13, 2018

That text has been the topic of many discussions over the years, with relatively recent changes (in March) for example at #852 and #854. You'll want to make a pretty strong case why your proposed formulation is better than the previous one and how it addresses the concerns of the many previous comments.

@propensive
Copy link
Contributor

Just to nudge this PR a little, @hepin1989, as @sjrd says, this text has always been difficult to change because it's some of the most important marketing for Scala, so I think there's a general unwillingness to merge changes unless there is a clear improvement, and agreement that it's definitely an improvement from the various stakeholders in Scala.

So I don't want to discourage you or anyone else from suggesting improvements to this text, because it is important, but there would need to be lots of support for any change. I don't feel confident enough merging this without more feedback from more people.

Ridiculous as this may sound, one approach may be to split this already-tiny PR into even smaller, incremental PRs than can be judged in isolation. It might also be necessary to encourage some other people in the community to share their comments.

So, I'm going to close this PR, but I don't believe it should be the end of the road for the changes you've proposed. They just need to be made in a way which is more amenable to being merged.

@propensive propensive closed this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants