Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StackOverflowError in PagedSeq.fromString #179

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix StackOverflowError in PagedSeq.fromString #179

merged 1 commit into from
Feb 15, 2019

Conversation

filipochnik
Copy link
Contributor

Fixes #178

@filipochnik
Copy link
Contributor Author

What do these test failures mean?

@Philippus
Copy link
Member

Seems not related to this PR, looks like something's changed with TravisCI related to installing JDK's.

@SethTisue SethTisue mentioned this pull request Jan 16, 2019
Closed
@SethTisue
Copy link
Member

I opened #181 on the JDK 6 thing

@SethTisue
Copy link
Member

@filipochnik can you rebase and see if that makes CI green?

@SethTisue
Copy link
Member

review by @Philippus and/or @gourlaysama?

Philippus
Philippus approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@Philippus Philippus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I checked that the test indeed fails on the old implementation.
I also did some basic comparing of the output of the two implementations.

@Philippus Philippus merged commit a78a862 into scala:1.1.x Feb 15, 2019
@Philippus Philippus mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Philippus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipochnik @Philippus @SethTisue