Skip to content

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Apr 11, 2019

Applying this PR will add Scala native to the build matrix again, looks like it was removed by accident in #184.

@Philippus Philippus force-pushed the add-scala-native-to-build-matrix branch from 5214c9a to 3a71b58 Compare April 11, 2019 19:15
@Philippus Philippus requested a review from SethTisue April 11, 2019 19:30
@SethTisue
Copy link
Member

SethTisue commented Apr 11, 2019

I've never followed Scala Native stuff so I don't know if the build change is okay. I'm fine with the re-addition though. Perhaps it will need some extra attention the next time we publish. If we add this it might be a good idea to roll a release relatively soon afterwards in order to make sure the releasing part works.

@SethTisue
Copy link
Member

oh I see #201 now, great minds think alike :-)

@Philippus Philippus merged commit d3ebdf1 into scala:1.2.x Apr 14, 2019
@Philippus Philippus deleted the add-scala-native-to-build-matrix branch April 14, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants