adapt to scala/scala#9292 #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
first commit was a blind stab, second commit was after I looked at it a bit closer. we can squash before merge, if this ends up being merged |
|
🩸 🔪 🙈 |
|
I would like to make the same offer as posco on twitter ("if you would like me to leave suggestions and comments"), except with puns and emoji. |
|
two puns please, and a side order of emoji, hold the pickle |
SethTisue
force-pushed
the
charsequence
branch
from
a4bba69 to
6fc0724
Compare
|
squashed. regardless of what happens to scala/scala#9292, I think this is code improvement and we should just merge it. |
Philippus
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.