Stack overflow with JavaTokenParsers.stringLiteral #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the regex engine.
|
Please note that this was originally reported here: https://github.com/scala/scala/issues/3017 |
|
Awesome, thanks! |
|
@pwagland, could you please sign the Scala CLA online? |
|
@adriaanm Done. CLA is signed. |
|
Congrats on the first contribution to the modularized parser combinators! Keep em coming :-) |
adriaanm
added a commit
that referenced
this pull request
Oct 8, 2013
Stack overflow with JavaTokenParsers.stringLiteral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular expression that is used to match stringLiterals cannot match strings longer than about 2500 characters. You might wonder why this would be required, still it isn't possible.
A very minor change to make the regext possessive fixes the problem, and won't cause any regressions, as backtracking is not possible in the regex anyway.