Skip to content

StdLexical now emits ErrorToken on unterminated string literals. #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

StdLexical now emits ErrorToken on unterminated string literals. #402

merged 1 commit into from
Jul 8, 2021

Conversation

martingd
Copy link
Contributor

Fixes issue #397

Philippus
Philippus requested changes Jul 3, 2021
View reviewed changes
Copy link
Member

@Philippus Philippus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the commits into one commit with interactive rebase?

@martingd
Copy link
Contributor Author

martingd commented Jul 5, 2021

@Philippus I have squashed my commits and rebased them on top of the current 2.x branch.

@SethTisue SethTisue merged commit e952ff4 into scala:2.x Jul 8, 2021
@SethTisue SethTisue mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Philippus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martingd @Philippus @SethTisue