Skip to content

Conversation

joshuakfarrar
Copy link

No description provided.

Test / test := {
val _ = (Test / g8Test).toTask("").value
},
scriptedLaunchOpts ++= List("-Xms1024m", "-Xmx1024m", "-XX:ReservedCodeCacheSize=128m", "-XX:MaxPermSize=256m", "-Xss2m", "-Dfile.encoding=UTF-8"),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxPermSize has been removed from Java.

@joshuakfarrar
Copy link
Author

hi, @scala-steward!

@joshuakfarrar joshuakfarrar changed the title Update to Scala 3.1.0 Upgrade to Scala 3.1.0 Nov 25, 2022
@aelfric
Copy link
Contributor

aelfric commented Dec 1, 2022

Since there are some more significant differences between Scala 2.13 and Scala 3, should there maybe be a separate Scala 3 template and leave this one tracking the latest patch versions of Scala 2.13

@eed3si9n
Copy link
Member

eed3si9n commented Dec 1, 2022

@aelfric There's https://github.com/scala/scala3.g8.

@SethTisue
Copy link
Member

SethTisue commented Dec 1, 2022

@joshuakfarrar seconded that for now anyway, we have separate Scala 2 and Scala 3 templates and this is the Scala 2 one. So we can't take that change, but the other changes LGTM.

However, the repo README really ought to be clear that this is the Scala 2 template, and it should link to the Scala 3 template for those who want that instead. Can I interest you in adding that change to this PR?

@SethTisue SethTisue closed this Feb 10, 2023
@SethTisue
Copy link
Member

the repo README really ought to be clear that this is the Scala 2 template, and it should link to the Scala 3 template for those who want that instead

I submitted this myself as #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants