Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala Native - Scala 3 #592

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Support Scala Native - Scala 3 #592

merged 3 commits into from
Mar 17, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Feb 3, 2022

Added a commit on top of #584

xuwei-k and others added 2 commits January 23, 2022 10:55
@lolgab lolgab marked this pull request as ready for review February 3, 2022 18:24
@sideeffffect
Copy link

Awesome work from @lolgab . Would be nice to have it integrated to scala-xml @ashawley ❤️

@TheElectronWill
Copy link

wow, the chain of dependencies is quite long 😄 I got there by following the links in softwaremill/sttp#1243

build.sbt Outdated Show resolved Hide resolved
Co-authored-by: Eric K Richardson <ekrichardson@gmail.com>
@SethTisue
Copy link
Member

SethTisue commented Mar 17, 2022

I see code that prevents attempting to build or publish for Scala 3.0 for Scala Native.

I don't see code that prevents non-Native platforms from double-publishing (on both 3.0 and 3.1). Am I missing something or am I wrong to expect that?

@ekrich
Copy link
Contributor

ekrich commented Mar 17, 2022

I think only for Scala 3.0.x not 3.1.x and higher - It has to do with de-reference syntax !ptr = value https://scala-native.readthedocs.io/en/latest/user/interop.html but I couldn't find the Dotty issue. Ok found it - it was a blocker in 3.0 that worked in Scala 2 - scala/scala3#13282

@SethTisue
Copy link
Member

SethTisue commented Mar 17, 2022

@ekrich I understand that Scala Native doesn't work on 3.0, only 3.1.

my question is about having both 3.0 and 3.1 in crossScalaVersions

to make this more concrete, basically my questions is, shouldn't the build do (pseudocode):

publish / skip := scalaVersion.value.startsWith("3.1") && platform != Native

because on JVM and JS, it doesn't make sense to publish on both 3.0 and 3.1; the artifacts are _3 either way

@SethTisue
Copy link
Member

ohhhhh, that already is in build.sbt:

    // Don't publish for Scala 3.1 or later, only from 3.0
    publish / skip := (CrossVersion.partialVersion(scalaVersion.value) match {
      case Some((3, x)) if x > 0 => true
      case _                     => false
    }),

it just isn't in the diffs for this PR — it was already there!

okay, that answers my question, sorry for the noise

@SethTisue
Copy link
Member

publishing ticket: #596

@lolgab
Copy link
Contributor Author

lolgab commented Mar 17, 2022

Thank you very much @SethTisue! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants