-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Scala Native - Scala 3 #592
Conversation
- Update Scala Native Scala 3 version to 3.1.1
wow, the chain of dependencies is quite long 😄 I got there by following the links in softwaremill/sttp#1243 |
Co-authored-by: Eric K Richardson <ekrichardson@gmail.com>
I see code that prevents attempting to build or publish for Scala 3.0 for Scala Native. I don't see code that prevents non-Native platforms from double-publishing (on both 3.0 and 3.1). Am I missing something or am I wrong to expect that? |
I think only for Scala 3.0.x not 3.1.x and higher - It has to do with de-reference syntax |
@ekrich I understand that Scala Native doesn't work on 3.0, only 3.1. my question is about having both 3.0 and 3.1 in to make this more concrete, basically my questions is, shouldn't the build do (pseudocode):
because on JVM and JS, it doesn't make sense to publish on both 3.0 and 3.1; the artifacts are |
ohhhhh, that already is in build.sbt: // Don't publish for Scala 3.1 or later, only from 3.0
publish / skip := (CrossVersion.partialVersion(scalaVersion.value) match {
case Some((3, x)) if x > 0 => true
case _ => false
}), it just isn't in the diffs for this PR — it was already there! okay, that answers my question, sorry for the noise |
publishing ticket: #596 |
Thank you very much @SethTisue! 🎉 |
Added a commit on top of #584