Message comparison in FilteringReporter strips trailing [quickfixable] #10521
Conversation
|
2 steps forward (by som), one back (by me) |
lrytz
force-pushed
the
filteringQuickfix
branch
from
86df4b4 to
361a97c
Compare
SethTisue
added
the
prio:hi
|
maybe try putting your shoes on backward. |
There was a problem hiding this comment.
Well that worked out. I just noticed javac prefixes the message as you had done, probably to make it easier to machine process?
Y.java:21: warning: [removal] ContentSignerParameters in com.sun.jarsigner has been deprecated and marked for removal
Maybe my issue with it was the length of [quickfixable]; [fixable] is the same length as [removal]. In ancient times, I remember log files with left-side columns that aligned nicely for visual scanning and machine parsing, ERR: com.acme: uhoh, or I don't remember exactly except that alignment mattered.
| private def stripQuickfixable(msg: String): String = { | ||
| val i = msg.indexOf(" [quickfixable]") | ||
| if (i > 0) msg.substring(0, i) else msg | ||
| } |
There was a problem hiding this comment.
I would have if (msg.endsWith(" [qfa]")) etc.
There was a problem hiding this comment.
I noticed it's not always at the end, the "Scala 3 migration messages are errors under -Xsource:3..." appendix is added in RunReporting, after [quickfixable].
There was a problem hiding this comment.
ok I'm sorry I updated your title.
som-snytt
changed the title
|
I updated the title to look more like the problem. |
SethTisue
removed
the
prio:hi
No description provided.