New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-4577 singleton type pattern test should use `eq`, not `==` #3558

Merged
merged 1 commit into from Feb 21, 2014

Conversation

Projects
None yet
3 participants
@adriaanm
Member

adriaanm commented Feb 19, 2014

I find it hard to imagine anyone is relying on case x: foo.type =>
erroneously being compiled to foo == x instead of the spec'ed foo eq x,
so let's finally fix this.

Maybe my imagination is lacking, so feel free to veto this, @retronym and @gkossakowski.

SI-4577 singleton type pattern test should use `eq`, not `==`
I find it hard to imagine anyone is relying on `case x: foo.type =>`
erroneously being compiled to `foo == x` instead of the spec'ed `foo eq x`,
so let's finally fix this.
@retronym

This comment has been minimized.

Show comment
Hide comment
@retronym

retronym Feb 20, 2014

Member

LGTM, so long as we release not prominently.

Member

retronym commented Feb 20, 2014

LGTM, so long as we release not prominently.

@adriaanm adriaanm added the reviewed label Feb 20, 2014

@adriaanm

This comment has been minimized.

Show comment
Hide comment
@adriaanm

adriaanm Feb 20, 2014

Member

noted (among other things): scala/make-release-notes#50
will add more next week

Member

adriaanm commented Feb 20, 2014

noted (among other things): scala/make-release-notes#50
will add more next week

@gkossakowski

This comment has been minimized.

Show comment
Hide comment
@gkossakowski

gkossakowski Feb 20, 2014

Member

LGTM.

Member

gkossakowski commented Feb 20, 2014

LGTM.

retronym added a commit that referenced this pull request Feb 21, 2014

Merge pull request #3558 from adriaanm/t4577
SI-4577 singleton type pattern test should use `eq`, not `==`

@retronym retronym merged commit e72f77b into scala:master Feb 21, 2014

1 check passed

default pr-scala Took 77 min.
Details

@adriaanm adriaanm deleted the adriaanm:t4577 branch Mar 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment