SI-4577 singleton type pattern test should use eq, not ==#3558
Merged
retronym merged 1 commit intoscala:masterfrom Feb 21, 2014
Merged
SI-4577 singleton type pattern test should use eq, not ==#3558retronym merged 1 commit intoscala:masterfrom
eq, not ==#3558retronym merged 1 commit intoscala:masterfrom
Conversation
I find it hard to imagine anyone is relying on `case x: foo.type =>` erroneously being compiled to `foo == x` instead of the spec'ed `foo eq x`, so let's finally fix this.
Member
|
LGTM, so long as we release not prominently. |
Contributor
Author
|
noted (among other things): scala/make-release-notes#50 |
Contributor
|
LGTM. |
retronym
added a commit
that referenced
this pull request
Feb 21, 2014
SI-4577 singleton type pattern test should use `eq`, not `==`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it hard to imagine anyone is relying on
case x: foo.type =>erroneously being compiled to
foo == xinstead of the spec'edfoo eq x,so let's finally fix this.
Maybe my imagination is lacking, so feel free to veto this, @retronym and @gkossakowski.