Avoid ClassfileAnnotation warning for @SerialVersionUID #4028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else restrictionWarning(cdef.pos, unit, | ||
| // Ignore @SerialVersionUID, because it is special-cased and handled completely differently. | ||
| // It only extends ClassfileAnnotationClass instead of StaticAnnotation to get the enforcement | ||
| // of constant argument values "for free". |
There was a problem hiding this comment.
Could you add a reference to SI-7041 in the comment?
|
@soc, will you have a chance to fix the comment today? Would like to 🚢 this as part of 2.11.3 release. |
|
🚢 for the win :D |
@serialversionuid is special-cased, the warning doesn't apply. Related to SI-7041.
|
@lrytz @gkossakowski @xeno-by Done. |
|
Oh wow! I didn't realize that there's a long history behind this change. Before I start digging I may ask @lrytz for opinion. |
|
LGTM! Thanks, @soc |
gkossakowski
added a commit
that referenced
this pull request
Oct 7, 2014
Avoid ClassfileAnnotation warning for @serialversionuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@serialversionuid is special-cased, the warning doesn't apply.
Related to SI-7041.