Fix memory leak in runtime reflections TypeTag caches #8470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep a weak reference to the TypeTag value stored in the ClassValue as it refers to the key.
|
Looks good to me. Thanks for fixing this quickly! |
diesalbla
approved these changes
Oct 20, 2019
| @@ -0,0 +1,30 @@ | |||
| import scala.reflect.runtime.universe | |||
There was a problem hiding this comment.
To follow the convention, perhaps we could call this t11767.scala.
There was a problem hiding this comment.
That would have helped me. A new PR fails this test, and I was like, where is that test, when was it deleted? Finally realized it was on 2.12 and also recent. However, TIL --full-history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a weak reference to the TypeTag value stored in the ClassValue as it refers
to the key.
Fixes scala/bug#11767