Backport "Make coverage more similar to the one in Scala 2" to 3.3 LTS #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WojciechMazur
force-pushed
the
backport-lts-3.3-23711
branch
from
5314284 to
ef50914
Compare
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4 to 5. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> [Cherry-picked 6c68061][modified]
Closes scala#21877 * removes coverage of inlined nodes (as mentioned in the accompanying comment, those are impossible to represent in most cases) * adds coverage for Literals (ones directly in Apply are omitted) * removes coverage of `throw` contents * if apply node is tagged, we do not tag it's prefix, outside of other prefixing Apply's arguments (eg. when we tag `a+b+c` we do not redundantly tag `a+b`) * allows instrumenting synthetic method calls (like apply of a case After all of these changes the statements tagged are much more similar to Scala 2, let's look at the scala#21877 minimisation: * Scala 2: <img width="704" height="364" alt="Zrzut ekranu 2025-08-12 o 17 07 31" src="https://github.com/user-attachments/assets/f647dfa5-973e-424f-9818-483b7d01d550" /> <img width="740" height="379" alt="Zrzut ekranu 2025-08-12 o 17 07 46" src="https://github.com/user-attachments/assets/09eca1c0-a202-4e5e-b3e4-0947d9e8662d" /> * Scala 3: <img width="623" height="360" alt="Zrzut ekranu 2025-08-12 o 17 08 48" src="https://github.com/user-attachments/assets/efd5baaa-9f52-4ad6-9ba6-2f5bde42a470" /> <img width="638" height="428" alt="Zrzut ekranu 2025-08-12 o 17 08 55" src="https://github.com/user-attachments/assets/01ff6cc6-c348-47db-8ae5-d758ca0bf302" /> There are some differences still remaining, most notably the tagging the DefDefs and its default parameters, but I left them for now, as those seem more useful than harmful. BEcouse of those changed most of the .covergae files had to be regenerated, however I want through each and every diff to make sure that all of those changes there are expected. Additionally, this PR also fixes scala#21695 (issue with certain generated Block nodes not having assigned the correct type, causing later undefined errors).
Closes scala#21877 * removes coverage of inlined nodes (as mentioned in the accompanying comment, those are impossible to represent in most cases) * adds coverage for Literals (ones directly in Apply are omitted) * removes coverage of `throw` contents * if apply node is tagged, we do not tag it's prefix, outside of other prefixing Apply's arguments (eg. when we tag `a+b+c` we do not redundantly tag `a+b`) * allows instrumenting synthetic method calls (like apply of a case After all of these changes the statements tagged are much more similar to Scala 2, let's look at the scala#21877 minimisation: * Scala 2: <img width="704" height="364" alt="Zrzut ekranu 2025-08-12 o 17 07 31" src="https://github.com/user-attachments/assets/f647dfa5-973e-424f-9818-483b7d01d550" /> <img width="740" height="379" alt="Zrzut ekranu 2025-08-12 o 17 07 46" src="https://github.com/user-attachments/assets/09eca1c0-a202-4e5e-b3e4-0947d9e8662d" /> * Scala 3: <img width="623" height="360" alt="Zrzut ekranu 2025-08-12 o 17 08 48" src="https://github.com/user-attachments/assets/efd5baaa-9f52-4ad6-9ba6-2f5bde42a470" /> <img width="638" height="428" alt="Zrzut ekranu 2025-08-12 o 17 08 55" src="https://github.com/user-attachments/assets/01ff6cc6-c348-47db-8ae5-d758ca0bf302" /> There are some differences still remaining, most notably the tagging the DefDefs and its default parameters, but I left them for now, as those seem more useful than harmful. BEcouse of those changed most of the .covergae files had to be regenerated, however I want through each and every diff to make sure that all of those changes there are expected. Additionally, this PR also fixes scala#21695 (issue with certain generated Block nodes not having assigned the correct type, causing later undefined errors). [Cherry-picked c535dbc][modified]
WojciechMazur
force-pushed
the
backport-lts-3.3-23722
branch
from
ef8d678 to
f5bc882
Compare
|
No regressions detected in the community build up to backport-lts-3.3-23816. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#23722 to the 3.3.7.
PR submitted by the release tooling.
[skip ci]