Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in Community Build: ScalaPB #4033

Closed
allanrenucci opened this issue Feb 22, 2018 · 4 comments
Closed

Regression in Community Build: ScalaPB #4033

allanrenucci opened this issue Feb 22, 2018 · 4 comments
Assignees
@nicolasstucki
Labels
area:community build itype:bug

Comments

@allanrenucci
Copy link
Contributor

https://travis-ci.org/lampepfl/dotty-community-build/jobs/344732706

#3342 seems to be the cause of the regression
@nicolasstucki
Copy link
Contributor

Fixed with #4145

@nicolasstucki
Copy link
Contributor

In that PR I stop forcing types on scala2 classes. One of which contained a macro in ScalaPB.

@liufengyun
Copy link
Contributor

So we can enable ScalaPB benchmarks again? I'll do it now.

@nicolasstucki
Copy link
Contributor

We should be able to re-enable them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
area:community build itype:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liufengyun @nicolasstucki @allanrenucci