Skip to content

Remove Expr.cast #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 8, 2020

Remove this alias of Expr.toExprOf and help avoid double casts such as seal.cast.

Migration

  • On Tree: .seal.cast[T] -> toExprOf[T]
  • On Expr: .cast[T] -> toExprOf[T] (no occurrences found in our code or community build)

@nicolasstucki nicolasstucki self-assigned this Nov 8, 2020
@nicolasstucki nicolasstucki marked this pull request as ready for review November 9, 2020 16:26
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Remove this alias of `Expr.toExprOf` and help avoid douple casts such as `seal.cast`.

__Migration__

* On `Tree`: `.seal.cast[T]` -> `toExprOf[T]`
* On `Expr`: `.cast[T]` -> `toExprOf[T]`
@nicolasstucki nicolasstucki merged commit ca216a8 into scala:master Nov 9, 2020
@nicolasstucki nicolasstucki deleted the remove-expr-cast branch November 9, 2020 21:11
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants