Remove methods that detected wrong classes loaded #10260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we load them from their .tasty which ensures that the class was generated by Scala 3 (not Scala 2 nor Java).
liufengyun
approved these changes
Nov 10, 2020
| cls.denot.infoOrCompleter match { | ||
| case _: NoLoader => Some(Scala2CompilationUnit(cls.fullName.toString)) | ||
| case _ if cls.flags.is(Flags.JavaDefined) => Some(JavaCompilationUnit(cls.fullName.toString)) | ||
| case _ => Some(AlreadyLoadedCompilationUnit(cls.denot.fullName.toString)) | ||
| } |
There was a problem hiding this comment.
The match is kept intentionally? Semantically, it can be removed.
There was a problem hiding this comment.
We should be able to remove it. But last time I tried there was a failure with some of the -from-tasty tests. As this is unrelated to the public API I left it for a second PR.
There was a problem hiding this comment.
I also left the comment above to not forget to remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we load them from their .tasty which ensures that the class was generated by Scala 3 (not Scala 2 nor Java).