Skip to content

Fix scala3doc GH actions #10575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

romanowski
Copy link
Contributor

@romanowski romanowski commented Dec 1, 2020

Now we run on pull_request as well as on push if branch contains master or scala3doc

This allows us to upload doc to remote storage from private forks that have secrets set

@romanowski romanowski force-pushed the scala3doc/fix-gh-action branch 6 times, most recently from 0286cff to 5460e2b Compare December 1, 2020 11:38
Now we run on pull_request as well as on push if branch contains master or scala3doc

This allows us to upload doc to remote storage from private forks that have secrets set
@romanowski romanowski force-pushed the scala3doc/fix-gh-action branch from 5460e2b to 8dd4bc1 Compare December 1, 2020 11:41
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will now only upload the docs when the secret is set, which means we'll follow normal GH safety restrictions. We can add the secret to forks to upload docs whenever a branch is pushed there.

@abgruszecki abgruszecki merged commit 77e2165 into scala:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants