-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community build: add cats and update cats-effect #10639
Conversation
3f457ef
to
a324399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is super useful, thank you!
I find it weird that running JS tests can exhaust the JVM heap, wdyt @sjrd ? Tests should be running using node and not rhino right? |
The GC thrashing seems to be triggered by:
|
c545439
to
678c9c0
Compare
Disabling full optimization for the Scala.js tests in cats seems to have solved the GC thrashing issue. On another note, we'll need to fork all the added projects to dotty-staging if we want to merge this. |
Ah yes, I think you should be able to create the forks since you're a member of the org. |
Until/unless this is merged upstream, we could do this in the community build config itself with |
am I? I only see collaborator access on dotty-staging/cats-effect, and am not seeing the option to fork to the dotty-staging org. |
Oops I thought you did, you should have access now. |
This is a dependency of cats
This is a dependency of cats and cats-effect-2
This is a dependency of cats-effect-3
This is a dependency of cats
Force fast optimization for Scala.js tests to avoid GC thrashing.
This is a transitive dependency of cats-effect-3
This is a dependency of cats-effect-3
678c9c0
to
6f64117
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dotty CI / community_build_b (pull_request) Successful in 71m
This is now much longer than community_build_a, maybe we should move some other projects to _a to balance things out?
An alternative to #10587.
Updates cats-effect-2 and cats-effect-3 in the community build to latest upstream. Rather than modifying upstream to use
withDottyCompat
as was done in #10587, here we add the dependencies to the community build.Projects added:
Fixes #10478