Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cats-effect-* is broken in the community build after bump to 3.0.0-RC1 #10478

Closed
griggt opened this issue Nov 24, 2020 · 9 comments · Fixed by #10639
Closed

cats-effect-* is broken in the community build after bump to 3.0.0-RC1 #10478

griggt opened this issue Nov 24, 2020 · 9 comments · Fixed by #10639
Assignees

Comments

@griggt
Copy link
Contributor

griggt commented Nov 24, 2020

Looks like a flaw in the build files somewhere, I have not looked further

Error:  scala.MatchError: 3.0.0-RC1-bin-SNAPSHOT (of class java.lang.String)
Error:  Use 'last' for the full log.
Error:  Test dotty.communitybuild.CommunityBuildTestB.catsEffect2 failed
@griggt
Copy link
Contributor Author

griggt commented Nov 24, 2020

It seems as if the bug is in the sbt-spiewak plugin. Should we just disable these two projects in the CB until it's fixed?

3.0.0-RC1-bin-SNAPSHOT isn't handled by:

https://github.com/djspiewak/sbt-spiewak/blob/c438ee9552d0382b4ef14eb9d13011cc0dc208e7/core/src/main/scala/sbtspiewak/FullScalaVersion.scala#L20-L47

@griggt
Copy link
Contributor Author

griggt commented Nov 25, 2020

Daniel kindly cut a new 0.18.1 release of sbt-spiewak containing a fix, however it's built with sbt 1.4.x (as are all versions >= 0.16.0)

@smarter are there still blockers on updating the build to use sbt 1.4?

@anatoliykmetyuk
Copy link
Contributor

anatoliykmetyuk commented Nov 25, 2020

Currently, we are a bit loaded by the final push for RC1. So far dropping Cats is the easiest solution FTTB. If there are indeed blockers for 1.4, bump to 1.4 before RC1 would unlikely be a priority. External help and PRs are always welcome ;)

@smarter
Copy link
Member

smarter commented Nov 25, 2020

I'm working on the 1.4 upgrade.

@smarter
Copy link
Member

smarter commented Nov 26, 2020

I took care of the 1.4 upgrade but I don't plan to work on restoring cats-effect in the community build, @anatoliykmetyuk is still the maintainer of the community build.

@griggt
Copy link
Contributor Author

griggt commented Dec 1, 2020

I've opened dotty-staging/cats-effect#2 to demonstrate the change needed to permit re-enabling cats-effect-2 in the community build. It's as simple as updating the version of the sbt-spiewak-sonatype plugin. The same can be done for cats-effect-3.

@smarter
Copy link
Member

smarter commented Dec 1, 2020

Sounds good to me, but if we can we might as well update cats-effect-2/3 to the latest upstream which should already have the updated plugins. If you want to give it a try I've given you write access to dotty-staging.

@griggt
Copy link
Contributor Author

griggt commented Dec 1, 2020

Sure. Upstream has moved to using Dotty built artifacts for most of its dependencies (cats-core, cats-laws, discipline-munit), which aren't (yet) in the community build. I don't think we want to take on adding all of those projects right now, so they'll just get the withDottyCompat treatment.

@smarter
Copy link
Member

smarter commented Dec 1, 2020

Ah that might complicate things, we should look into adding these projects in our build (cats especially would be very useful) though if withDottyCompat works that's ok for now too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants