Fix JSR-45 repositioning #10801
Merged
Fix JSR-45 repositioning #10801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Dec 15, 2020
liufengyun
approved these changes
Dec 15, 2020
| @@ -252,7 +253,8 @@ object Inliner { | |||
| case tree: Bind => finalize(untpd.Bind(tree.name, transform(tree.body))(curSource)) | |||
| case tree: TypeTree => finalize(tpd.TypeTree(tree.tpe)) | |||
| case tree: DefTree => super.transform(tree).setDefTree | |||
| case _ => super.transform(tree) | |||
| case EmptyTree => tree | |||
| case _ => fixSpan(super.transform(tree)) | |||
There was a problem hiding this comment.
I thought finalize will ensure fixSpan is called. Just curious if there is something to fix for TreeCopier.
There was a problem hiding this comment.
Probably not. This kind of span/source change is only done here. When we will finally support JSR-45 we will remove all this code anyway.
There was a problem hiding this comment.
I was thinking about overridding def postProcess in TreeCopier:
class Reposition extends TreeMap(cpyWithNewSource) {
override val cpy: TypedTreeCopier = new TypedTreeCopier() {
protected def postProcess(tree: Tree, copied: untpd.Tree): copied.ThisTree[T] = ...
protected def postProcess(tree: Tree, copied: untpd.MemberDef): copied.ThisTree[T] = ...
}
}No need to address in this PR.
There was a problem hiding this comment.
Maybe. I would not worry to much about this code and just port the support JSR-45 from Scala 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10799 that fixes the root cause of the issue.