Check GADT ordering for HKTs in TypeComparer #11910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the current TypeComparer calls
GadtConstraint.bounds
to check GADT bounds of HKTs, the GADT ordering between two HK type parameters will not be available when comparing them. The following snippet illustrates the issue.The orderings will be available via
fullBounds
, but this method may result in dead loops if used in TypeComparer. This PR fixes this issue by checking ordering constraints between HKTs withisLess
in TypeComparer.@abgruszecki