Fix negative literals #12459
Closed
Fix negative literals #12459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `-` followed by a number is considered a literal only if there are no spaces between the sign and the first digit. Also, some simplifications how negative numbers are parsed.
|
See https://contributors.scala-lang.org/t/functional-syntax/5062 for discussion |
|
On reflection, it’s not worth to change things wrt to Scala 2. So we’ll leave it as it is. |
|
I was prepared to backport because it's a small change and it's good puzzler territory or as they say in french terroir. Also the alignment with leading infix was elegant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
-followed by a number is considered a literal only if there are no spacesbetween the sign and the first digit.
Also, some simplifications how negative numbers are parsed.