Skip to content

Conversation

megri
Copy link
Contributor

@megri megri commented May 14, 2021

This includes everything under the /docs folder and nothing else: sources and scaladoc still refer to 'compilation unit'

@som-snytt
Copy link
Contributor

It's OK for popular literature, but if they took my idea to take a directory of files as a single compilation unit, then obviously the equivalence would fail. (People complained that if companions have to be in a single file, then the file gets too big. Why can't it be two files.)

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with the change for user-facing docs but let's keep "compilation unit" for old blog posts and for docs in internals. The compiler has CompilationUnits and SourceFiles and they are different. Misnaming them is bound to confuse.

So I'd keep only the changes under docs/reference and docs/usage.

@odersky odersky assigned megri and unassigned odersky May 26, 2021
file'.

This includes everything under the /docs folder and nothing else:
sources and scaladoc still refer to 'compilation unit'
@megri megri force-pushed the rename-compilation-unit-to-source-file-in-docs branch from f819891 to 596e6df Compare May 26, 2021 11:21
@megri
Copy link
Contributor Author

megri commented May 26, 2021

OK with the change for user-facing docs but let's keep "compilation unit" for old blog posts and for docs in internals. The compiler has CompilationUnits and SourceFiles and they are different. Misnaming them is bound to confuse.

So I'd keep only the changes under docs/reference and docs/usage.

Updated now

@smarter smarter merged commit 229ec59 into scala:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants