Detect provisional superclasses and recompute in Typer #12912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When computing an implied superclass in `ensureFirstIsClass` we might get the wrong class because some parent classes don't have their parents set yet. Detect that case and recompute the superclass in Typer.
odersky
changed the title
dwijnand
reviewed
Jul 6, 2021
| @@ -18,6 +18,7 @@ object MiMaFilters { | |||
| exclude[MissingClassProblem]("scala.annotation.experimental"), | |||
| exclude[MissingClassProblem]("scala.annotation.internal.ErasedParam"), | |||
| exclude[MissingClassProblem]("scala.annotation.internal.ErasedParam"), | |||
| exclude[MissingClassProblem]("scala.annotation.internal.ProvisionalSuperClass"), | |||
There was a problem hiding this comment.
Btw there's glob support in mima's exclusions so you can use scala.annotation.internal.* here next time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring that the first parent of a class or trait is a class is done in completion.
But at that point some necessary info might not be computed yet, since not all base classes
of parent classes are guaranteed to be known at that point. We cannot move the transform
to regular typing since that breaks too many assumptions.
Instead we detect the problematic case in Namer and recompute the superclass in Typer.
Fixes #12722