Skip to content

Allow IntSetting's to be set with a colon #13267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Allow IntSetting's to be set with a colon #13267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363c0d6
Allow IntSetting's to be set with a colon
dwijnand Aug 6, 2021
38a27db
Add a test for IntSetting's setting with a colon
dwijnand Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dotty/tools/dotc/config/Settings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ object Settings:
val output = if (isJar) JarArchive.create(path) else new PlainDirectory(path)
update(output, args)
}
case (IntTag, arg2 :: args2) =>
case (IntTag, _) =>
val arg2 :: args2 = if (argRest == "") args else argRest :: args
try {
val x = arg2.toInt
choices match {
Expand Down
12 changes: 12 additions & 0 deletions compiler/test/dotty/tools/dotc/SettingsTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,18 @@ class SettingsTests {
assertEquals(expectedErrors, summary.errors)
}

@Test def `Allow IntSetting's to be set with a colon`: Unit =
object Settings extends SettingGroup:
val foo = IntSetting("-foo", "foo", 80)
import Settings._

val args = List("-foo:100")
val summary = processArguments(args, processAll = true)
assertTrue(s"Setting args errors:\n ${summary.errors.take(5).mkString("\n ")}", summary.errors.isEmpty)
withProcessedArgs(summary) {
assertEquals(100, foo.value)
}

private def withProcessedArgs(summary: ArgsSummary)(f: SettingsState ?=> Unit) = f(using summary.sstate)

extension [T](setting: Setting[T])
Expand Down