Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specs2-core to the community build #13782

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

etorreborre
Copy link

@etorreborre etorreborre commented Oct 21, 2021

I will expand it with the rest of the specs2 modules if this one goes well

@etorreborre etorreborre changed the title Added specs2 Added specs2-core to the community build Oct 21, 2021
@etorreborre
Copy link
Author

Sorry I thought I had already signed the CLAs. Can you please restart the build?

@etorreborre
Copy link
Author

@nicolasstucki do you know what's wrong with the build? I can't see any obvious failure

@nicolasstucki
Copy link
Contributor

I restarted the CI tests

@symbiont-eric-torreborre
Copy link
Contributor

@nicolasstucki @anatoliykmetyuk I updated the PR to avoid some specs2 tests

@etorreborre
Copy link
Author

@nicolasstucki @anatoliykmetyuk I tried a different approach for passing sbt arguments. Can you please start the workflow again?

@etorreborre
Copy link
Author

@nicolasstucki @anatoliykmetyuk I am trying something else in order to attempt pass to pass arguments to sbt when running the specs2 tests. I hope this one will work. If it doesn't I will need some guidance on how to best do this :-).
Thanks!

I also tried to run the CommunityBuildC locally but I had other failures. I don't know what the easy to try to fix the problem locally without bothering you each time.

@anatoliykmetyuk
Copy link
Contributor

@etorreborre thanks for all the work adding the project! Could you please point the submodule to this repo instead? https://github.com/dotty-staging/specs2 – I also added you as a maintainer to it. All of the community projects reside under dotty-staging organisation to allow for easy fixes of breakages.

@etorreborre
Copy link
Author

@anatoliykmetyuk I did the change you suggested. Can you please tell me now how I can fix the broken community c job? This is not clear to me. Also, can you start the workflow again because maybe my latest change of the sbt test command worked?

@anatoliykmetyuk anatoliykmetyuk merged commit 5ce25fe into scala:master Nov 9, 2021
@etorreborre
Copy link
Author

I'm glad to see that eventually everything worked out ok. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants