Skip to content

fix completions to properly contain public fields if they were shadowed #15236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2022
Merged

fix completions to properly contain public fields if they were shadowed #15236

merged 3 commits into from
May 20, 2022

Conversation

rochala
Copy link
Contributor

@rochala rochala commented May 19, 2022

Fixes #15235

@rochala rochala requested a review from prolativ May 19, 2022 14:59
tgodzik
tgodzik approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metals tests pass! 🎉

@rochala rochala merged commit d1d4fc5 into scala:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@prolativ prolativ prolativ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No completions for parent class values shadowed by non public values from class constructor
3 participants
@rochala @tgodzik @prolativ