Skip to content

minor improvements to developer docs for Scaladoc tool #16769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

minor improvements to developer docs for Scaladoc tool #16769

merged 1 commit into from
Jul 13, 2023

Conversation

SethTisue
Copy link
Member

this comes out of the notes I made while working on #15927 with @yzia2000 and @jan-pieter -- can either of you guys think of anything else we should add?

@yzia2000
Copy link
Contributor

Thanks for doing this!

yzia2000
yzia2000 reviewed Jan 26, 2023
View reviewed changes
yzia2000
yzia2000 reviewed Jan 26, 2023
View reviewed changes
@SethTisue SethTisue self-assigned this Jan 26, 2023
@SethTisue SethTisue marked this pull request as draft January 26, 2023 19:31
@SethTisue SethTisue mentioned this pull request Feb 1, 2023
Closed
@Sporarum
Copy link
Contributor

Sporarum commented Feb 2, 2023

Amazing work !

In the same spirit, I would encourage you to add the command to https://docs.scala-lang.org/scala3/guides/contribution/procedures-testing.html

@ckipp01
Copy link
Member

ckipp01 commented May 9, 2023

I don't want perfect to get in the way of better. @SethTisue is there anything else you wanted to add to this, or is it good to be reviewed?

@ckipp01 ckipp01 self-requested a review May 9, 2023 17:47
@SethTisue
Copy link
Member Author

@ckipp01 I'll try to get back to this within the next couple weeks

@SethTisue
Copy link
Member Author

I would encourage you to add the command to docs.scala-lang.org/scala3/guides/contribution/procedures-testing.html

Good suggestion — I added a link from that page to this page.

@SethTisue SethTisue marked this pull request as ready for review July 13, 2023 00:35
ckipp01
ckipp01 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @SethTisue. LGTM!

@ckipp01 ckipp01 merged commit f9247ec into scala:main Jul 13, 2023
@SethTisue SethTisue deleted the improve-scaladoc-developer-docs branch July 13, 2023 13:08
@Kordyjan Kordyjan mentioned this pull request Nov 23, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "minor improvements to developer docs for Scaladoc tool" to …
b100d2b 
…LTS (#19066)

Backports #16769 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

+1 more reviewer

@yzia2000 yzia2000 yzia2000 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@SethTisue SethTisue

Labels

area:doctool area:documentation

Projects

None yet

Milestone

3.3.2

Development

Successfully merging this pull request may close these issues.

5 participants

@SethTisue @yzia2000 @Sporarum @ckipp01 @Kordyjan