Skip to content

WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 30, 2023
Merged

WUnused: Fix for symbols with synthetic names and unused transparent inlines #17061

merged 8 commits into from
Mar 30, 2023

Conversation

szymon-rd
Copy link
Contributor

Resolves #16863

@szymon-rd szymon-rd force-pushed the wunused-fix-trans-inline-and-synth-names branch 4 times, most recently from 5a46c7b to 2230a07 Compare March 8, 2023 13:52
@szymon-rd szymon-rd requested a review from KacperFKorban March 8, 2023 13:53
KacperFKorban
KacperFKorban reviewed Mar 8, 2023
View reviewed changes
@szymon-rd szymon-rd force-pushed the wunused-fix-trans-inline-and-synth-names branch 3 times, most recently from a4683b9 to f90da34 Compare March 13, 2023 14:21
@szymon-rd szymon-rd requested a review from KacperFKorban March 13, 2023 14:32
@szymon-rd szymon-rd force-pushed the wunused-fix-trans-inline-and-synth-names branch from f90da34 to 97bdd0d Compare March 13, 2023 15:42
KacperFKorban
KacperFKorban approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Just added one last nitpick.

@szymon-rd szymon-rd force-pushed the wunused-fix-trans-inline-and-synth-names branch from 59fb54d to 56b484d Compare March 28, 2023 16:06
@szymon-rd
Copy link
Contributor Author

I think I will omit the symbols with $ altogether for now due to a lot of edge cases (evidence, Type[A] in macros, etc.).

@szymon-rd szymon-rd merged commit 00bb3fe into scala:main Mar 30, 2023
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Apr 12, 2023
@Kordyjan Kordyjan added this to the 3.3.0 backports milestone Apr 12, 2023
@Kordyjan Kordyjan mentioned this pull request Apr 13, 2023
Closed
@szymon-rd szymon-rd mentioned this pull request Apr 13, 2023
Closed
@Kordyjan Kordyjan mentioned this pull request Apr 14, 2023
Merged
Kordyjan added a commit that referenced this pull request Apr 17, 2023
@Kordyjan
Backport "WUnused: Fix for symbols with synthetic names and unused tr…
423bd1e 
…ansparent inlines" (#17274)

Backports #17061
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Apr 17, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 1, 2023
@som-snytt
Copy link
Contributor

In case I read this later, I'm restoring warning for modules X$; moving the phase to after staging for the Type problem; absolved a few types (DummyImplicit, =:=, <=<). Also warns for context bounds. Does not warn on contextual parameter.

@som-snytt
Copy link
Contributor

@som-snytt dude! you're a life-saver. I didn't actually save that commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

Assignees

@szymon-rd szymon-rd

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

-Wunused gives endless false positives on macros
4 participants
@szymon-rd @som-snytt @KacperFKorban @Kordyjan