Skip to content

Disable WUnused for params of non-private defs #17223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2023
Merged

Disable WUnused for params of non-private defs #17223

merged 4 commits into from
Apr 13, 2023

Conversation

szymon-rd
Copy link
Contributor

@szymon-rd szymon-rd commented Apr 10, 2023 •
edited
Loading

Fix #17185

@Kordyjan Kordyjan added this to the 3.3.0 backports milestone Apr 12, 2023
@Kordyjan Kordyjan added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 12, 2023
@szymon-rd szymon-rd marked this pull request as ready for review April 13, 2023 13:33
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Apr 13, 2023
@Kordyjan Kordyjan enabled auto-merge April 13, 2023 13:56
@szymon-rd szymon-rd mentioned this pull request Apr 13, 2023
Closed
@szymon-rd szymon-rd changed the title WIP: Disable WUnused for params of non-private defs Disable WUnused for params of non-private defs Apr 13, 2023
@Kordyjan Kordyjan merged commit 083027e into scala:main Apr 13, 2023
@Kordyjan Kordyjan mentioned this pull request Apr 14, 2023
Merged
Kordyjan added a commit that referenced this pull request Apr 17, 2023
@Kordyjan
Backport "Disable WUnused for params of non-private defs" (#17280)
7809f9b 
Backports #17223
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Apr 17, 2023
@Kordyjan Kordyjan modified the milestones: 3.3.0 backports, 3.3.1, 3.3.0 Aug 1, 2023
@mbovel mbovel mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kordyjan Kordyjan Kordyjan approved these changes

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

WUnused: Ignore unused params of non-private methods that are members of non-final classlikes
2 participants
@szymon-rd @Kordyjan