Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Include top-level symbols from same file in outer ambiguity error" #17438

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Revert "Include top-level symbols from same file in outer ambiguity error" #17438

merged 1 commit into from
Jun 12, 2023

Conversation

nicolasstucki
Copy link
Contributor

This reverts commit 7d4e103.

Reverts #17033
Closes #17433

@nicolasstucki nicolasstucki requested a review from lrytz May 9, 2023 06:56
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented May 9, 2023 •
edited
Loading

Merge this only in case #17433 (comment) does not work out.

See #17439

@nicolasstucki nicolasstucki marked this pull request as ready for review May 9, 2023 08:40
@SethTisue SethTisue marked this pull request as draft May 9, 2023 21:39
@nicolasstucki nicolasstucki marked this pull request as ready for review May 24, 2023 08:48
sjrd
sjrd approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the dotty meeting.

@sjrd sjrd merged commit 6071005 into scala:main Jun 12, 2023
17 checks passed
@sjrd sjrd deleted the close-17433 branch June 12, 2023 13:46
@lrytz
Copy link
Member

lrytz commented Jun 12, 2023

The real fix is available at #17439

@lrytz lrytz mentioned this pull request Jun 26, 2023
Open
@lrytz lrytz mentioned this pull request Jul 10, 2023
Merged
This was referenced Jul 11, 2023
Closed
Merged
@Kordyjan Kordyjan added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Jul 11, 2023
Kordyjan added a commit that referenced this pull request Jul 11, 2023
@Kordyjan
Backport "Revert "Include top-level symbols from same file in outer a…
ee42e03 
…mbiguity error"" (#18182)

Backports #17438
Reverts #17033 that slipped through the cracks and got into 3.3.1,
causing a regression.
@Kordyjan Kordyjan added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 11, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
@Kordyjan Kordyjan modified the milestones: 3.4.0, 3.3.1 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

@lrytz lrytz Awaiting requested review from lrytz

Assignees

@lrytz lrytz

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Ambigious types errors by picking nested/derived type and type defined in the same package
4 participants
@nicolasstucki @lrytz @sjrd @Kordyjan