Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Vphases takes names to mark, -Vprint is typer #17563

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented May 23, 2023

-Vphases optionally takes a list of phase names to highlight in the output.

-Vprint optionally takes a list of phase names for printing, and defaults to typer.

setting.isPresent if the user supplied the option; setting.userValue is the optional value supplied by the user.

If a setting has an empty default, an explicit argument must be supplied.

A couple of phase names are normalized to camelCase.

-Vprint loosely matches the phase name (contains), so do the same for -Vphases. (Would be nice to ignore upper/lower case.)

E.g., -Vphases:checkUnused,elimByName highlights both phases so that it's easy to find the miniphase of interest.

image

image

@som-snytt som-snytt marked this pull request as ready for review May 23, 2023 17:41
@som-snytt som-snytt force-pushed the tweak/show-phase branch 2 times, most recently from dffc44c to 84d4dd9 Compare May 12, 2024 08:26
@som-snytt som-snytt marked this pull request as draft May 12, 2024 08:27
Distinguish whether a setting was "set" by the user.
@som-snytt
Copy link
Contributor Author

Checking -Vphases does not work in Run, but that is not urgent. Other settings that represent phase names could be added to settings to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant