Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quote-nested-6.check #17993

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Update quote-nested-6.check #17993

merged 1 commit into from
Jun 19, 2023

Conversation

mbovel
Copy link
Member

@mbovel mbovel commented Jun 17, 2023 •
edited

Fixes #17992.

@dwijnand dwijnand enabled auto-merge June 18, 2023 08:35
@dwijnand dwijnand mentioned this pull request Jun 18, 2023
Merged
@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jun 19, 2023 •
edited

The CI job got canceled. I restarted it.

Could it be a bug in #17915?

@nicolasstucki nicolasstucki mentioned this pull request Jun 19, 2023
Merged
@ckipp01
Copy link
Member

ckipp01 commented Jun 19, 2023

The CI job got canceled. I restarted it.

Could it be a bug in #17915?

Something isn't working right with this as I see main is also getting cancelled and never should. I created #18001 for now and will look further into it.

@nicolasstucki nicolasstucki mentioned this pull request Jun 19, 2023
Merged
@nicolasstucki
Copy link
Contributor

Re-running CI again. This time they should not get canceled.

@mbovel
Copy link
Member Author

mbovel commented Jun 19, 2023

Rebased on top of #18001, let's see if the jobs can run now.

@dwijnand dwijnand merged commit ac2879e into scala:main Jun 19, 2023
15 checks passed
@mbovel mbovel deleted the mb/fix-quote-nested-6 branch June 19, 2023 12:34
@Kordyjan Kordyjan mentioned this pull request Nov 23, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "Update quote-nested-6.check" to LTS (#19025)
5f01616 
Backports #17993 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@nicolasstucki nicolasstucki Awaiting requested review from nicolasstucki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2023-06-17 failed
5 participants
@mbovel @nicolasstucki @ckipp01 @dwijnand @Kordyjan