Refactor TASTy Attributes #19091
Merged
Refactor TASTy Attributes #19091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2023
bishabosha
reviewed
Nov 27, 2023
| val scala2StandardLibrary: Boolean, | ||
| val explicitNulls: Boolean, | ||
| ) | ||
| val booleanTags: List[Int], |
There was a problem hiding this comment.
It could. I will try to optimize this in a separate PR. Will merge as is to unblock the other PRs.
bishabosha
approved these changes
Nov 27, 2023
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 27, 2023
We generalize the internal encoding of `Attributes` to be a list of tags. Then we add add helper methods to have simpler ways to interact with this abstraction using booleans. This implies that the pickling/unpickling can be agnostic of the semantics of each tag. Therefore reducing the number of places that need to be updated when we add a new tag. Useful for scala#19074, scala#19033, and scala#18948.
sjrd
reviewed
Nov 27, 2023
Comment on lines
+14
to
+15
| while !isAtEnd do | ||
| booleanTags += readByte() |
There was a problem hiding this comment.
Hum, ouch. We shouldn't do that. we should actively refuse to read any unknown tag. Tags may be non-boolean in the future (e.g., source file). This implementation would too easily "fail to fail" on incompatible extensions.
There was a problem hiding this comment.
I will add non-boolean tags in #18948. Those concerns are addressed there already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generalize the internal encoding of
Attributesto be a list of tags. Then we add add helper methods to have simpler ways to interact with this abstraction using booleans. This implies that the pickling/unpickling can be agnostic of the semantics of each tag. Therefore reducing the number of places that need to be updated when we add a new tag.Useful for #19074, #19033, and #18948.