Define Predef.assert overwrite directly in Scala 2 library TASTy
#19231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
Predef.assert overwrite directly in Scala 2 library TASTy
nicolasstucki
force-pushed
the
override-scala-predef
branch
5 times, most recently
from
a4ac534
to
ce75b49
Compare
nicolasstucki
force-pushed
the
override-scala-predef
branch
from
ce75b49
to
b94f1f5
Compare
nicolasstucki
force-pushed
the
override-scala-predef
branch
8 times, most recently
from
f442519
to
7df2efa
Compare
nicolasstucki
added a commit
that referenced
this pull request
Dec 20, 2023
This command allow us to quickly see the diff between the original library and the overwritten files in `scala2-library-bootstrapped/src`. Instructions are printed with `scala2-library-bootstrapped/run` as with other commands for `scala2-library-bootstrapped`. Extracted from #18967. Also useful for #19231.
nicolasstucki
force-pushed
the
override-scala-predef
branch
2 times, most recently
from
bf04c2d
to
690e61b
Compare
nicolasstucki
force-pushed
the
override-scala-predef
branch
2 times, most recently
from
2ba3903
to
45aee96
Compare
Define `assert` in `scala.Predef` instead `scala.runtime.stdLibPatches.Predef`. We assume that all patches to `scala.Predef` are inline methods, therefore if we see an inline method in `scala.Predef` we do not patch it with the method in `scala.runtime.stdLibPatches.Predef`.
nicolasstucki
force-pushed
the
override-scala-predef
branch
from
45aee96
to
ba0eb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[test_scala2_library_tasty]