Prioritise sequence-matches over product-sequence-matches #19260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Dec 14, 2023
|
|
||
| class Test: | ||
| def m1(t1: T1): Unit = t1 match | ||
| case VarExt(c1, cs*) => // CCE: class P1 cannot be cast to class E1 |
There was a problem hiding this comment.
Should this test be a run test, in order to exercise this?
There was a problem hiding this comment.
Can do. At some point I was curious as to what the code would do if I made it compile without the TypeTestCasts compile error, and it indeed threw. But this part of the code I just left as potentially useful debugging if returned to. But we can also make it actually part of the test.
There was a problem hiding this comment.
If it's not actually part of testing #19221 per se, then it can be left as is.
sjrd
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.