Parse search query param in Scaladoc #19669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I'll get to this tomorrow |
Florian3k
approved these changes
Feb 20, 2024
WojciechMazur
added a commit
that referenced
this pull request
Jul 2, 2024
Backports #19669 to the LTS branch. PR submitted by the release tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaladoc in Scala 2 supported a
searchquery parameter that would immediately send an user to the search result page.This was used by search engines to integrate with Scaladoc (e.g. searching
Future !scalain Duck Duck Go would send a user straight to the results of searchingFuture).This PR adds the same functionality to the new Scaladoc.
I also needed to update
scala-js-dom, as otherwiseURLSearchParamswas not available.