Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol reference retrivial for scala.caps.Caps #20493

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented May 29, 2024

Fixes #20556
The scala.caps.Cap was changed from opaque type to class in #18463
It could have lead to compiler crash when trying to reference it, eg in tminglei/slick-pg - see Open CB logs probably by entering some unexpected paths

@WojciechMazur WojciechMazur merged commit c68e594 into scala:main Jun 17, 2024
23 checks passed
@WojciechMazur WojciechMazur deleted the fix/caps-defns branch June 17, 2024 10:26
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
@WojciechMazur WojciechMazur added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Jul 10, 2024
@WojciechMazur WojciechMazur modified the milestones: 3.5.1, 3.5.0 Jul 10, 2024
WojciechMazur added a commit that referenced this pull request Jul 11, 2024
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:done This PR was successfully backported. labels Jul 11, 2024
@WojciechMazur WojciechMazur modified the milestones: 3.5.0, 3.5.1 Jul 12, 2024
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: object caps does not have a member type Cap
2 participants